Cmake: fix libatomic detection on macOS #13944
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On macOS, the build currently fails with:
because CMake unconditionally adds
-latomicwhen the builtin atomic probe fails.However:
libatomiclibatomicat allWhat this patch does
This patch refines the detection logic:
-latomicentirely on Apple platforms.-latomicusingunsigned __int128(a more reliable trigger for architectures that actually need it).
find_library(atomic)and only add-latomicif it exists.This avoids build failures on macOS while preserving correct behavior on Linux
platforms where
-latomicis truly required.Reproduction (macOS 15.6.1, Apple clang 17.0.0)
Before this patch:
After this patch: